-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4558 Fix coverage and XML results for async tests #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -205,12 +205,11 @@ jobs: | |
python-version: '3.8' | ||
- name: Start MongoDB | ||
uses: supercharge/mongodb-github-action@1.10.0 | ||
- name: Run Test | ||
- name: Run connect test from sdist | ||
shell: bash | ||
run: | | ||
cd sdist/test | ||
ls | ||
which python | ||
pip install -e ".[test]" | ||
pytest -v | ||
pytest -v test/asynchronous/ | ||
PYMONGO_MUST_CONNECT=1 pytest -v test/test_client_context.py | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has this test been just running the wrong suite this whole time? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No but it just seems unnessecary to run the whole suite from the sdist, we already run the whole suite elsewhere on the same commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is a clean solution. Do we still need
$TEST_ARGS
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST_ARGS is still used to add
--cov
.