PYTHON-2940 Fix spec tests that require DNSPython #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Oct 13, 2021
test/test_uri_spec.py
Outdated
| @@ -181,6 +182,12 @@ def create_tests(test_path): | |||
| scenario_def = json.load(scenario_stream) | |||
|
|
|||
| for testcase in scenario_def['tests']: | |||
| if (testcase['uri'].startswith("mongodb+srv") and not | |||
| _HAVE_DNSPYTHON): | |||
There was a problem hiding this comment.
Done. At least I think so.
There was a problem hiding this comment.
The indentation is still off.
ShaneHarvey
requested changes
Oct 13, 2021
test/test_uri_spec.py
Outdated
| @@ -181,6 +182,12 @@ def create_tests(test_path): | |||
| scenario_def = json.load(scenario_stream) | |||
|
|
|||
| for testcase in scenario_def['tests']: | |||
| if (testcase['uri'].startswith("mongodb+srv") and not | |||
| _HAVE_DNSPYTHON): | |||
There was a problem hiding this comment.
The indentation is still off.
ShaneHarvey
requested changes
Oct 13, 2021
test/test_uri_spec.py
Outdated
| @@ -181,6 +182,12 @@ def create_tests(test_path): | |||
| scenario_def = json.load(scenario_stream) | |||
|
|
|||
| for testcase in scenario_def['tests']: | |||
| if (testcase['uri'].startswith(SRV_SCHEME) and not | |||
There was a problem hiding this comment.
Please move this skipping logic to the run_scenario method above and use self.skip(...) instead of print.
ShaneHarvey
requested changes
Oct 13, 2021
test/test_uri_spec.py
Outdated
| @@ -92,7 +93,10 @@ def run_scenario(self): | |||
| compressors = (test.get('options') or {}).get('compressors', []) | |||
| if 'snappy' in compressors and not _HAVE_SNAPPY: | |||
| self.skipTest('This test needs the snappy module.') | |||
|
|
|||
| if (test['uri'].startswith(SRV_SCHEME) and not | |||
| _HAVE_DNSPYTHON): | |||
There was a problem hiding this comment.
This should be one line now.
test/test_uri_spec.py
Outdated
| if (test['uri'].startswith(SRV_SCHEME) and not | ||
| _HAVE_DNSPYTHON): | ||
| self.skipTest("Skipping test '%s' because you need DNSPython for " | ||
| "mongodb+srv URIs" % dsc) |
ShaneHarvey
approved these changes
Oct 13, 2021
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.