Skip to content

PYTHON-2940 Fix spec tests that require DNSPython #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2021
Merged

PYTHON-2940 Fix spec tests that require DNSPython #756

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c42882
first commit
juliusgeo Oct 13, 2021
968cb4e
fix code style (hopefully)
juliusgeo Oct 13, 2021
2d6dc5b
shane fixes
juliusgeo Oct 13, 2021
920a315
change indentation
juliusgeo Oct 13, 2021
1bb5135
fix test skip message
juliusgeo Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/test_uri_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@

from pymongo.common import INTERNAL_URI_OPTION_NAME_MAP, validate
from pymongo.compression_support import _HAVE_SNAPPY
from pymongo.uri_parser import parse_uri
from pymongo.srv_resolver import _HAVE_DNSPYTHON
from pymongo.uri_parser import parse_uri, SRV_SCHEME
from test import clear_warning_registry, unittest


Expand Down Expand Up @@ -92,7 +93,8 @@ def run_scenario(self):
compressors = (test.get('options') or {}).get('compressors', [])
if 'snappy' in compressors and not _HAVE_SNAPPY:
self.skipTest('This test needs the snappy module.')

if test['uri'].startswith(SRV_SCHEME) and not _HAVE_DNSPYTHON:
self.skipTest("This test needs dnspython package.")
valid = True
warning = False

Expand Down