RUBY-1650 Rewrite connection handshake flow to not recurse #1254
Conversation
p-mongo
force-pushed
the
1650
branch
3 times, most recently
from
5eee2bd to
02d9fa2
Compare
|
This PR also removes client key caching, with https://jira.mongodb.org/browse/RUBY-1213 reopened to reinstate it. |
| return res | ||
| specific_address = FAMILY_MAP[info[4]].new(info[3], port, host) | ||
| socket = specific_address.socket( | ||
| connect_timeout, ssl_options, connect_timeout: connect_timeout) |
There was a problem hiding this comment.
Why doesn't this need to call connect! anymore?
There was a problem hiding this comment.
Sockets are now completely initialized by their constructors.
There was a problem hiding this comment.
From looking at the diff, I don't see any actual changes in functionality to the constructors. Could you point out to me where the changes were made?
There was a problem hiding this comment.
https://github.com/mongodb/mongo-ruby-driver/pull/1254/files#diff-ed625ecdabf4aeff5d1a5fc04b958a3aR86 for SSL socket, https://github.com/mongodb/mongo-ruby-driver/pull/1254/files#diff-cc511f0e87683f58982606a59e0f3657R70 for TCP socket, Unix sockets were already completely initialized by their constructor and had a no-op connect! method.
There was a problem hiding this comment.
Hmm, not sure why I missed them. Thanks!
No description provided.