Skip to content

RUBY-1562 Retryable reads spec tests #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

RUBY-1562 Retryable reads spec tests #1340

merged 1 commit into from
Apr 8, 2019

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Apr 5, 2019

Spec tests only to keep the other PRs smaller.

@p-mongo p-mongo requested a review from saghm April 5, 2019 21:05
saghm
saghm approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@saghm saghm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already decided that we weren't going to do reviews for YAML-only changes? Either way, you can just merge any futures changes that only touch YAML files without needing to request my review.

@p-mongo p-mongo merged commit 1282c53 into mongodb:master Apr 8, 2019
@p-mongo p-mongo deleted the 1562-spec-tests branch April 8, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@saghm saghm saghm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-mongo @saghm @p