RUBY-1761 URI option fixes #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ized values to fail later
| If the maxStalenessSeconds URI option value is -1, the option is ignored. | ||
| If the option value is an integer, the Ruby option is set to the | ||
| specified value (but note that the value should be either 0 or greater | ||
| than 90, while accepted by the driver, may cause errors during operations). |
There was a problem hiding this comment.
I'm a little confused by this. Which values may cause errors during operations?
There was a problem hiding this comment.
Clarified the language here.
saghm
approved these changes
Jul 22, 2019
p-mongo
added a commit
that referenced
this pull request
Jul 22, 2019
* RUBY-1881 fix double unescaping of replica set uri option * RUBY-1881 fix double unescaping of auth source uri option * RUBY-1763 pass through unknown values of read preference modes * RUBY-1761 accept all cases for canonicalize host name * RUBY-1882 use standard integer parser for pool size uri options * RUBY-1882 use standard bool parser * RUBY-1882 use one millisecond converter * RUBY-1882 use standard integer converter for wtimeout * RUBY-1882 extract a common inverse bool converter * RUBY-1761 reference local decode helper * RUBY-1881 fix double unescaping of read preference tags * RUBY-1761 reduce line length * RUBY-1882 dry tls/ssl option handling * RUBY-1764 do not warn on max staleness value of -1 * RUBY-1551 test empty authSource uri option * RUBY-1883 allow uri options string to begin with & * RUBY-1762 fix max_staleness documentation in URI options * RUBY-1756 document auth mechanism value conversions and pass unrecognized values to fail later * RUBY-1762 clarify max staleness URI option language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/RUBY-1761