RUBY-1884 time out background thread waits after about 10 seconds #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
| # @param [ Hash ] options The options. | ||
| # | ||
| # @option options [ Logger ] :logger A custom logger to use. | ||
| def initialize(pool, options = {}) | ||
| @pool = pool | ||
| @options = @pool.options |
There was a problem hiding this comment.
This line can be deleted
There was a problem hiding this comment.
I seem to have missed this, what options did the populator use before?
There was a problem hiding this comment.
The populator includes Loggable, so that’s what the options were used for before. Now that the Background Thread includes Loggable, I think the “includes Loggable” line also can be deleted.
There was a problem hiding this comment.
Okay removed that too.
| end | ||
|
|
||
| let(:populator) do | ||
| described_class.new(pool, pool.options) |
There was a problem hiding this comment.
Should we be doing some kind of clean up for the populator after the test is run?
There was a problem hiding this comment.
This is probably a good idea.
|
Rebased to fix the test suite. |
saghm
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.