Skip to content

RUBY-2035 Use URI::DEFAULT_PARSER.unescape instead of URI.decode for Ruby 2.7 #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2019
Merged

RUBY-2035 Use URI::DEFAULT_PARSER.unescape instead of URI.decode for Ruby 2.7 #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mongo/uri.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ def raise_invalid_error_no_fmt!(details)
end

def decode(value)
::URI.decode(value)
::URI::DEFAULT_PARSER.unescape(value)
end

def encode(value)
Expand Down
2 changes: 1 addition & 1 deletion spec/mongo/uri_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@
let(:servers) { '%2Ftmp%2Fmongodb-27017.sock' }

it 'returns an array with the parsed server' do
expect(uri.servers).to eq([URI.unescape(servers)])
expect(uri.servers).to eq([URI::DEFAULT_PARSER.unescape(servers)])
end
end

Expand Down