Skip to content

RUBY-1999 MONGODB-AWS Support #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 9, 2020
Merged

RUBY-1999 MONGODB-AWS Support #1788

merged 8 commits into from
Apr 9, 2020

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Mar 14, 2020 •
edited
Loading

No description provided.

@p-mongo p-mongo force-pushed the 1999 branch 4 times, most recently from d648f8c to d977412 Compare March 20, 2020 23:48
@p-mongo p-mongo force-pushed the 1999 branch 2 times, most recently from 6178682 to 148d1ec Compare March 26, 2020 16:49
@p-mongo p-mongo changed the title RUBY-1999 expand x509 auth special treatment to the concept of fixed users RUBY-1999 MONGODB-AWS Support Mar 26, 2020
@p-mongo
Copy link
Contributor Author

p-mongo commented Mar 26, 2020

https://jira.mongodb.org/browse/RUBY-1999

@p-mongo p-mongo force-pushed the 1999 branch 3 times, most recently from 2d78fcf to 93b0acd Compare March 28, 2020 21:49
@p-mongo p-mongo force-pushed the 1999 branch 3 times, most recently from c9b870f to 8d1a540 Compare April 8, 2020 02:23
@p-mongo p-mongo changed the title RUBY-1999 MONGODB-AWS Support RUBY-1999 MONGODB-AWS Support Apr 8, 2020
@p-mongo p-mongo force-pushed the 1999 branch 2 times, most recently from f16269a to 36b4857 Compare April 8, 2020 02:26
@p-mongo p-mongo requested review from ShaneHarvey and egiurleo April 9, 2020 04:14
egiurleo
egiurleo approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions but otherwise this is looking good.

.evergreen/lib/server_setup.rb Outdated
else
raise 'Expected the bootstrap user to had been deleted, but it was not'
end
=end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a scenario in which this code should be un-commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, removed it to https://gist.github.com/p-mongo/2829f9fece71753b40133ae0d180fcb2.

.evergreen/test-on-docker
@@ -29,6 +29,9 @@ class Runner

opts.on("-a", "--add-env=PATH", "Load environment variables from PATH in .env format") do |path|
@options[:extra_env] ||= {}
unless File.exist?(path)
raise "-a option references nonexistent file #{path}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this.

lib/mongo/auth.rb
@@ -58,6 +58,7 @@ module Auth
#
# @since 2.0.0
SOURCES = {
aws: Aws,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would make sense to eventually change the other auth class names to all be written in the same style (i.e. Ldap, Scram, etc)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to but we can't do this until driver 3.0.

spec/README.aws-auth.md
would need to specify MONGO_RUBY_DRIVER_AWS_AUTH_USER_ARN in your
`.env.private` file with the ARN of the user to add to MongoDB. The easiest
way to find out this value is to run the tests and note which username the
test suite is trying to authenticate as.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last sentence is unclear to me -- how do you find the ARN from the username?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARN is the username.

spec/integration/aws_credentials_retriever_spec.rb
@@ -61,8 +61,7 @@
)

orchestrator.clear_instance_profile(Utils.ec2_instance_id)
# Wait for change to propagate
sleep 5
Utils.wait_for_no_instance_profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

ShaneHarvey
ShaneHarvey reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the test-mlaunch evergreen failures expected?

@p-mongo
Copy link
Contributor Author

p-mongo commented Apr 9, 2020

JRuby builds tend to fail in varying amounts so some failures are expected.

@p-mongo p-mongo merged commit 7f8ae21 into mongodb:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-mongo @ShaneHarvey @egiurleo @p