RUBY-1999 Always raise timeout exceptions with the custom message. #1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously on Ruby 2.3 the custom timeout message was ignored. This commit reraises the exception raised by core Timeout library with the custom message provided by the user, so that on all Ruby versions the custom message is utilized.
egiurleo
approved these changes
Apr 6, 2020
p-mongo
pushed a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Apr 6, 2020
* master: RUBY-1999 provisioning and tooling changes to support testing ecs in evergreen (mongodb#1848) RUBY-1999 add default route to vpc setup (mongodb#1847) RUBY-1999 Always raise timeout exceptions with the custom message. (mongodb#1846) RUBY-1552 Document Ruby Kerberos usage (mongodb#1845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/RUBY-1999