RUBY-2168 Support speculative authentication attempts in isMaster #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
|
This PR breaks Kerberos since its code is separate from the driver. This will be hopefully dealt with in #1843. |
egiurleo
approved these changes
May 5, 2020
| # but at this point we don't know the mechanism that ultimately | ||
| # will be used (since this depends on the data returned by | ||
| # the handshake, specifically server version). | ||
| # However, we know that since only 4.4+ servers support speculative |
There was a problem hiding this comment.
I think this since is extraneous.
There was a problem hiding this comment.
I think you are right, this blurb had more stuff in it previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.