RUBY-2345 Validate that documents don't exceed maxBsonObjectSize on servers older than 3.6 #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 10, 2020 18:44
egiurleo
changed the title
p-mongo
approved these changes
Aug 12, 2020
egiurleo
pushed a commit
that referenced
this pull request
Aug 12, 2020
…ervers older than 3.6 (#2055)
egiurleo
pushed a commit
that referenced
this pull request
Aug 12, 2020
…ervers older than 3.6 (#2055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I separated the max bson size from the bson overhead in the
serializearguments. I did this in order to be able to check the document size without the overhead, them combine them to check the message size.