RUBY-2458 Link heartbeat succeeded/failed to started events #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
durran
suggested changes
Dec 2, 2020
lib/mongo/monitoring.rb
Outdated
| @@ -328,14 +328,20 @@ def publish_heartbeat(server, awaited: false) | |||
| rescue => exc | |||
| if monitoring? | |||
| event = Event::ServerHeartbeatFailed.new( | |||
| server.address, Time.now-start_time, exc, awaited: awaited) | |||
| server.address, Time.now-start_time, exc, | |||
There was a problem hiding this comment.
Bit of a nit but I would expect all parameters do be on new lines or not - not a combination of them.
lib/mongo/monitoring.rb
Outdated
| failed(SERVER_HEARTBEAT, event) | ||
| end | ||
| raise | ||
| else | ||
| if monitoring? | ||
| event = Event::ServerHeartbeatSucceeded.new( | ||
| server.address, Time.now-start_time, awaited: awaited) | ||
| server.address, Time.now-start_time, |
|
All of the positional parameters were on the same line but I made each of them take up their own line as you requested. |
p-mongo
pushed a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Dec 3, 2020
* master: RUBY-2459 Include connection purpose in platform metadata (mongodb#2148) RUBY-2458 Link heartbeat succeeded/failed to started events (mongodb#2147) RUBY-2446 Fix intermittent SDAM test failures (mongodb#2145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.