Fix RUBY-2558 :secondary_preferred read preference in 3.6+ sharded clusters performs primary read #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
p-mongo
force-pushed
the
2558
branch
6 times, most recently
from
407d360 to
66bd58d
Compare
…usters performs primary read
alcaeus
approved these changes
Apr 8, 2021
| # In replica sets and sharded clusters, read preference is passed | ||
| # to the server if one is specified by the application, and there | ||
| # is no default. | ||
| read && read.slave_ok? || false |
There was a problem hiding this comment.
Question without knowing internal semantics, why does this require || false to be included? Asking because A || false will always evaluate to A in boolean algebra, so I'm wondering about what Ruby does when read evaluates to a false-ish value.
There was a problem hiding this comment.
The || false converts nil to false (when read is nil, in this case).
Comment on lines
97
to
99
| # If the read preference contains only mode and mode is secondary | ||
| # preferred and we are sending to a pre-OP_MSG server, this read | ||
| # preference is indicated by the :slave_ok wire protocol flag. |
There was a problem hiding this comment.
Took me a moment to realise that the comment explains when the $readPreference option doesn't need to be added. Maybe add another sentence like "In all other cases, add the $readPreference option" might help clarify this.
There was a problem hiding this comment.
Sure, I added a note to this effect.
* master: Use frozen strings by default (mongodb#2202) RUBY-2561 Remove skipReason from estimatedDocumentCount test in versioned API (mongodb#2203)
p-mongo
added a commit
that referenced
this pull request
Apr 9, 2021
p-mongo
added a commit
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.