Skip to content

RUBY-2524 Snapshot reads #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2021
Merged

RUBY-2524 Snapshot reads #2362

merged 2 commits into from
Oct 26, 2021

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Oct 25, 2021 •
edited
Loading

No description provided.

@p-mongo p-mongo changed the title RUBY-2524 2524 RUBY-2524 Snapshot reads Oct 25, 2021
@p-mongo
Copy link
Contributor Author

p-mongo commented Oct 25, 2021

https://jira.mongodb.org/browse/RUBY-2524

@p-mongo p-mongo requested a review from comandeo October 25, 2021 15:55
comandeo
comandeo approved these changes Oct 26, 2021
View reviewed changes
lib/mongo/error/snapshot_session_invalid_server_version.rb Outdated
module Mongo
class Error

# Exception raised if a transaction is attempted on a snapshot session.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment here should be about server version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixed!

@p-mongo p-mongo merged commit e10bbba into mongodb:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@comandeo comandeo comandeo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-mongo @comandeo @p