-
Notifications
You must be signed in to change notification settings - Fork 532
RUBY-3361 Test x509 authentication on Atlas #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors Atlas connectivity tests to support X.509 authentication testing alongside existing regular authentication methods. The changes replace the old single-purpose operations test with a comprehensive connectivity test suite that can handle multiple authentication mechanisms.
- Replaces single ping test with structured connectivity tests for regular and X.509 authentication
- Adds support for X.509 certificate-based authentication using base64-encoded certificates
- Updates CI configuration to pass all necessary Atlas environment variables for both authentication types
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
spec/atlas/operations_spec.rb | Removed - old single-purpose ping test |
spec/atlas/atlas_connectivity_spec.rb | Enhanced with shared examples and X.509 authentication support |
.evergreen/run-tests-atlas.sh | Simplified by removing custom test status handling |
.evergreen/config/standard.yml.erb | Updated task name and display name for clarity |
.evergreen/config/common.yml.erb | Added X.509 environment variables and removed old task group |
.evergreen/config.yml | Same changes as common.yml.erb applied to generated config |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM from what I can see. Happy to merge if the connectivity tests pass.
No description provided.