Skip to content

Conversation

comandeo-mongo
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 12:27
@comandeo-mongo comandeo-mongo requested a review from a team as a code owner August 13, 2025 12:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Atlas connectivity tests to support X.509 authentication testing alongside existing regular authentication methods. The changes replace the old single-purpose operations test with a comprehensive connectivity test suite that can handle multiple authentication mechanisms.

  • Replaces single ping test with structured connectivity tests for regular and X.509 authentication
  • Adds support for X.509 certificate-based authentication using base64-encoded certificates
  • Updates CI configuration to pass all necessary Atlas environment variables for both authentication types

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
spec/atlas/operations_spec.rb Removed - old single-purpose ping test
spec/atlas/atlas_connectivity_spec.rb Enhanced with shared examples and X.509 authentication support
.evergreen/run-tests-atlas.sh Simplified by removing custom test status handling
.evergreen/config/standard.yml.erb Updated task name and display name for clarity
.evergreen/config/common.yml.erb Added X.509 environment variables and removed old task group
.evergreen/config.yml Same changes as common.yml.erb applied to generated config

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

comandeo-mongo and others added 4 commits August 13, 2025 14:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM from what I can see. Happy to merge if the connectivity tests pass.

@comandeo-mongo comandeo-mongo merged commit 56e37c1 into mongodb:master Aug 14, 2025
183 of 202 checks passed
@comandeo-mongo comandeo-mongo deleted the 3661 branch August 14, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants