Skip failing test against latest sharded clusters #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
force-pushed
the
skip-failing-crud-test
branch
from
0176ff0 to
9335e7d
Compare
kmahar
commented
Sep 27, 2021
| "unacknowledged-bulkWrite-replace-hint-clientError": ["*"] | ||
| ] | ||
| // Skipping due to a bug in server latest. TODO: SWIFT-1359 unskip | ||
| let client = try MongoClient.makeTestClient() |
There was a problem hiding this comment.
we don't really have a way in the runner itself to do conditional skips based on server version/topology, it seems, besides editing changes into the JSON files which didn't seem like a great approach.
patrickfreed
approved these changes
Sep 28, 2021
isabelatkinson
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear when the server team will fix this issue, so skipping for now to make the waterfall less red.