Skip to content

Skip failing test against latest sharded clusters #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Skip failing test against latest sharded clusters #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Tests/MongoSwiftSyncTests/CrudTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ final class CrudTests: MongoSwiftTestCase {
asType: UnifiedTestFile.self
)
let runner = try UnifiedTestRunner()
let skipList: [String: [String]] = [
var skipList: [String: [String]] = [
// libmongoc chose not to implement CDRIVER-3630 in anticipation of DRIVERS-1340,
// so we cannot pass these tests for now.
// TODO: DRIVERS-1340 unskip
Expand All @@ -106,6 +106,13 @@ final class CrudTests: MongoSwiftTestCase {
"unacknowledged-bulkWrite-update-hint-clientError": ["*"],
"unacknowledged-bulkWrite-replace-hint-clientError": ["*"]
]
// Skipping due to a bug in server latest. TODO: SWIFT-1359 unskip
let client = try MongoClient.makeTestClient()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really have a way in the runner itself to do conditional skips based on server version/topology, it seems, besides editing changes into the JSON files which didn't seem like a great approach.

if try client.serverVersion() >= ServerVersion(major: 5, minor: 1, patch: 0)
&& client.topologyType().isSharded
{
skipList["aggregate-out-readConcern"] = ["readConcern available with out stage"]
}
try runner.runFiles(files.map { $0.1 }, skipTests: skipList)
}
}
Expand Down