Skip to content

SERVER-22480 All DocumentSource's member variable names should start with an underscore #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

SERVER-22480 All DocumentSource's member variable names should start with an underscore #1226

wants to merge 4 commits into from

Conversation

d-d-ddl
Copy link
Contributor

@d-d-ddl d-d-ddl commented Mar 21, 2018

No description provided.

@cswanson310 cswanson310 self-requested a review March 22, 2018 22:47
@cswanson310 cswanson310 self-assigned this Mar 22, 2018
cswanson310
cswanson310 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@cswanson310 cswanson310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'm running it through the tests now but don't expect any failures. I can push tomorrow if all goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswanson310 cswanson310 cswanson310 approved these changes

Assignees

@cswanson310 cswanson310

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-d-ddl @cswanson310