Skip to content

Fix server-33111 spurious split dwarf builds #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdbaddog
Copy link
Contributor

- Fix spurious rebuilds on second build for cases where builder has > 1 target and the source file
  is generated. This was causing the > 1th target to not have it's implicit list cleared when the source
  file was actually built, leaving an implicit list similar to follows for 2nd and higher target
          ['/usr/bin/python', 'xxx', 'yyy', 'zzz']
  This was getting persisted to SConsign and on rebuild it would be corrected to be similar to this
          ['zzz', 'yyy', 'xxx', '/usr/bin/python']
  Which would trigger a rebuild because the order changed.
  The fix involved added logic to mark all shared targets as peers and then ensure they're implicit
  list is all cleared together.

bdbaddog added 2 commits April 1, 2019 14:48
…target (potentially only when that 2nd or higher target is added in the emitter were not getting their implicit list cleared after a generated source is rebuilt. Thus leading to the implicit list order being incorrect when written to sconsign leaded to spurious rebuilds on second build
@acmorrow acmorrow closed this in 7bf320d Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant