Skip to content

SERVER-10626 $add projection supports arrays of numbers #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SERVER-10626 $add projection supports arrays of numbers #476

wants to merge 1 commit into from

Conversation

astral303
Copy link

Adds nested arrays if provided. Retains nullish behavior if null is part of input.

Adds nested arrays if provided. Retains nullish behavior if provided.
@kangas
Copy link
Contributor

kangas commented Aug 28, 2013

Hi Oleg,

Thank you for creating a SERVER ticket as requested in our CONTRIBUTING.rst document. Have you also signed the contributor's agreement at http://www.mongodb.com/contributor ? I need this before I can hand a pull request off for review.

Also, I noticed that your pull request is against the v2.4 branch. You will need to rebase this against our master branch and resubmit. It does not currently apply cleanly against master:

######################################################################## 100.0%
Applying: $add projection supports arrays of numbers. SERVER-10626
error: patch failed: src/mongo/db/pipeline/expression.cpp:345
error: src/mongo/db/pipeline/expression.cpp: patch does not apply
error: patch failed: src/mongo/db/pipeline/expression.h:325
error: src/mongo/db/pipeline/expression.h: patch does not apply
Patch failed at 0001 $add projection supports arrays of numbers. SERVER-10626

Thank you for contributing to MongoDB!

@kangas
Copy link
Contributor

kangas commented Aug 29, 2013

Oleg, I see that you signed the contributor's agreement. Thanks! I'll wait for this to be rebased against master.

@astral303
Copy link
Author

Hi Matt, yes, I will have this rebased soon! We are running 2.4, but I understand that this kind of change is too drastic for 2.4. Thanks!

@benety benety changed the title $add projection supports arrays of numbers. SERVER-10626 SERVER-10626 $add projection supports arrays of numbers May 13, 2014
@benety
Copy link
Contributor

benety commented Jun 23, 2014

@benety
Copy link
Contributor

benety commented Jun 25, 2014

Hi Oleg,

Based on @andy10gen's feedback in the SERVER ticket, I'm closing this pull request but I will leave the SERVER ticket open for further discussion and future pull requests.

Regards,
Ben

@benety benety closed this Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants