SERVER-1201 SERVER-3153 Showing UUID binary types better #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UUIDs can already be created easily by using:
UUID('hex-string')
However, they were still printed as BinData(3, 'base64') which
makes it difficult to debug.
This patch will print UUID objects in the same way as they
can be created, i.e. using the UUID('hex-string') format.
Fixes SERVER-1201
benety
changed the title
benety
changed the title
|
Hi Victor, Unfortunately, this is not as straightforward as it seems because we have to deal with 2 subtypes for UUID (3 and 4). For a more in-depth discussion, please see the comments in: https://jira.mongodb.org/browse/SERVER-3153 We are closing this pull request for now. Thank you, |
patrickfreed
pushed a commit
that referenced
this pull request
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUIDs can already be created easily by using:
UUID('hex-string')
However, they were still printed as BinData(3, 'base64') which
makes it difficult to debug.
This patch will print UUID objects in the same way as they
can be created, i.e. using the UUID('hex-string') format.
Fixes SERVER-1201