SERVER-14835 - fix fassert 16143 on PPC64 LE systems in LogFile::synchronousAppend() #766
Conversation
src/mongo/util/logfile.cpp
Outdated
There was a problem hiding this comment.
This fails compilation on non-Linux platforms.
There was a problem hiding this comment.
Well I'm a Linux dev, I'd be glad to know the equivalent on other systems. I'll propose it again with these and their calls between #ifdefs
There was a problem hiding this comment.
There's a set of #includes in the same file for non-Windows code around lines 160-165. You can move these #includes there and wrap linux/fs.h with linux.
|
Hi Corentin, Thank you for submitting this pull request - this looks more promising than #735. There are a couple of issues (see inlined comments) to resolve before I hand this over to the other reviewers. I was able to rebase your patch on a6b9d6d. For future reference, if the patch applies to both master and 2.6, please submit against master and we'll back port to the 2.6 branch when the pull request is merged. Thanks |
src/mongo/util/logfile.cpp
Outdated
There was a problem hiding this comment.
Can we make g_minOSPageSizeBytes the default for _blkSize and move the ioctl call into the the O_DIRECT #ifdef...#endif block around lines 186-195
|
Hi @corentinbaron, I've added some additional feedback (see inlined comments). Hopefully this will get back to working across all platforms. Ben |
|
Replaced by #769 |
2 participants
new version, using ioctl(_fd, BLKBSZGET) and fixed predefined alignment for PPC64.