Skip to content

CLOUDP-183839: Atlas Cli liveMigrations create doesn't parse output correctly after creating #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2023
Merged

CLOUDP-183839: Atlas Cli liveMigrations create doesn't parse output correctly after creating #2008

merged 3 commits into from
Jun 15, 2023

Conversation

swattyT
Copy link
Contributor

@swattyT swattyT commented Jun 14, 2023 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-# CLOUDP-183839

Changed the response template for liveMigration create and describe commands.
Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

swattyT
swattyT commented Jun 15, 2023
View reviewed changes
internal/cli/atlas/livemigrations/create.go
var createTemplate = `ID PROJECT ID SOURCE PROJECT ID STATUS
{{.Id}} {{.Destination.GroupId}} {{.Source.GroupId}} {{.Status}}`
var createTemplate = `ID LAGTIME READY FOR CUTOVER STATUS
{{.Id}} {{.LagTimeSeconds}} {{.ReadyForCutover}} {{.Status}}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the template as the API does not send Source and Destination in the response object.

@swattyT swattyT changed the title CLOUDP-183839: Update the response CLOUDP-183839: Atlas Cli liveMigrations create doesn't parse output correctly after creating Jun 15, 2023
@swattyT swattyT marked this pull request as ready for review June 15, 2023 09:54
@swattyT swattyT requested a review from a team as a code owner June 15, 2023 09:54
@swattyT swattyT requested review from a team and andreaangiolillo June 15, 2023 09:54
gssbzn
gssbzn approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please include a rlease notes mentioning the change of output on the ticket

@swattyT swattyT merged commit 81dc816 into master Jun 15, 2023
@swattyT swattyT deleted the CLOUDP-183839 branch June 15, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swattyT @gssbzn