Skip to content

CLOUDP-183839: Atlas Cli liveMigrations create doesn't parse output correctly after creating #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2023
Merged

CLOUDP-183839: Atlas Cli liveMigrations create doesn't parse output correctly after creating #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cba37e
CLOUDP-183839: Update the response
swattyT Jun 14, 2023
4f42fa0
removed leftover code
swattyT Jun 14, 2023
6e4fed4
lint fix
swattyT Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/atlascli/command/atlas-liveMigrations-create.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,6 @@ If the command succeeds, the CLI returns output similar to the following sample.

.. code-block::

ID PROJECT ID SOURCE PROJECT ID STATUS
<Id> <Destination.GroupId> <Source.GroupId> <Status>
ID LAGTIME READY FOR CUTOVER STATUS
<Id> <LagTimeSeconds> <ReadyForCutover> <Status>

4 changes: 2 additions & 2 deletions docs/mongocli/command/mongocli-atlas-liveMigrations-create.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,6 @@ If the command succeeds, the CLI returns output similar to the following sample.

.. code-block::

ID PROJECT ID SOURCE PROJECT ID STATUS
<Id> <Destination.GroupId> <Source.GroupId> <Status>
ID LAGTIME READY FOR CUTOVER STATUS
<Id> <LagTimeSeconds> <ReadyForCutover> <Status>

4 changes: 2 additions & 2 deletions internal/cli/atlas/livemigrations/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func (opts *CreateOpts) initStore(ctx context.Context) func() error {
}
}

var createTemplate = `ID PROJECT ID SOURCE PROJECT ID STATUS
{{.Id}} {{.Destination.GroupId}} {{.Source.GroupId}} {{.Status}}`
var createTemplate = `ID LAGTIME READY FOR CUTOVER STATUS
{{.Id}} {{.LagTimeSeconds}} {{.ReadyForCutover}} {{.Status}}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the template as the API does not send Source and Destination in the response object.


func (opts *CreateOpts) Run() error {
if err := opts.Prompt(); err != nil {
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/atlas/livemigrations/describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ func (opts *DescribeOpts) initStore(ctx context.Context) func() error {
}
}

var describeTemplate = `ID PROJECT ID SOURCE PROJECT ID STATUS
{{.Id}} {{.Destination.GroupId}} {{.Source.GroupId}} {{.Status}}`
var describeTemplate = `ID LAGTIME READY FOR CUTOVER STATUS
{{.Id}} {{.LagTimeSeconds}} {{.ReadyForCutover}} {{.Status}}`

func (opts *DescribeOpts) Run() error {
r, err := opts.store.LiveMigrationDescribe(opts.ConfigProjectID(), opts.liveMigrationID)
Expand Down