Skip to content

Conversation

s-urbaniak
Copy link
Collaborator

Summary

This is just a small fix to use the reconciler's For method. Right now they are separate.

Proof of Work

existing unit tests.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@s-urbaniak s-urbaniak marked this pull request as ready for review June 25, 2025 12:46
@s-urbaniak s-urbaniak requested a review from a team as a code owner June 25, 2025 12:46
Comment on lines +81 to +82
obj := &akov2.AtlasThirdPartyIntegration{}
return obj, ctrlrtbuilder.WithPredicates(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: obj is not required right?

Suggested change
obj := &akov2.AtlasThirdPartyIntegration{}
return obj, ctrlrtbuilder.WithPredicates(
return &akov2.AtlasThirdPartyIntegration{}, ctrlrtbuilder.WithPredicates(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, copy-pasta

@josvazg josvazg merged commit bfcbfff into main Jun 25, 2025
142 of 144 checks passed
@josvazg josvazg deleted the for branch June 25, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants