Skip to content

add For method in controller #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

add For method in controller #2415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions internal/controller/atlasthirdpartyintegrations/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,23 +78,20 @@ func NewAtlasThirdPartyIntegrationsReconciler(

// For prepares the controller for its target Custom Resource; AtlasThirdPartyIntegration
func (r *AtlasThirdPartyIntegrationHandler) For() (client.Object, builder.Predicates) {
return &akov2.AtlasThirdPartyIntegration{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})
obj := &akov2.AtlasThirdPartyIntegration{}
return obj, ctrlrtbuilder.WithPredicates(
Comment on lines +81 to +82
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: obj is not required right?

Suggested change
obj := &akov2.AtlasThirdPartyIntegration{}
return obj, ctrlrtbuilder.WithPredicates(
return &akov2.AtlasThirdPartyIntegration{}, ctrlrtbuilder.WithPredicates(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, copy-pasta

predicate.Or(
mckpredicate.AnnotationChanged("mongodb.com/reapply-period"),
predicate.GenerationChangedPredicate{},
),
mckpredicate.IgnoreDeletedPredicate[client.Object](),
)
}

func (h *AtlasThirdPartyIntegrationHandler) SetupWithManager(mgr ctrl.Manager, rec reconcile.Reconciler, defaultOptions controller.Options) error {
h.Client = mgr.GetClient()
obj := &akov2.AtlasThirdPartyIntegration{}
return controllerruntime.NewControllerManagedBy(mgr).
For(
obj,
ctrlrtbuilder.WithPredicates(
predicate.Or(
mckpredicate.AnnotationChanged("mongodb.com/reapply-period"),
predicate.GenerationChangedPredicate{},
),
mckpredicate.IgnoreDeletedPredicate[client.Object](),
),
).
For(h.For()).
Watches(
&akov2.AtlasProject{},
handler.EnqueueRequestsFromMapFunc(h.integrationForProjectMapFunc()),
Expand Down
Loading