- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.8k
feat(NODE-5510)!: dont filter change stream options #4723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    billouboq
  
              
              reviewed
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
              
                    tadjik1
  
              
              reviewed
              
                  
                    Oct 20, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks for your work @durran! I have one minor question/suggestion in the code.
Co-authored-by: Sergey Zelenov <sergey.zelenov@mongodb.com>
              
                    baileympearson
  
              
              previously requested changes
              
                  
                    Oct 20, 2025 
                  
              
              
            
            
              
                    dariakp
  
              
              previously approved these changes
              
                  
                    Oct 20, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI check
              
                    tadjik1
  
              
              approved these changes
              
                  
                    Oct 21, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Allows unspecified options that are part of the $changeStream stage to be passed through to the server.
Summary of Changes
What is the motivation for this change?
NODE-5510
Release Highlight
Change Streams No Longer Whitelist $changeStream Stage Options
Uses are now able to pass any option to
collection.watch()and if it is invalid in the $changeStream stage of the pipeline the server will error. This is to allow users to provide newly added options quickly that are not in our public types.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript