Skip to content

Conversation

@addaleax
Copy link
Contributor

The fact that we have two files in this directory which only differ by casing messes up checkouts on case-insensitive filesystems, like the default macOS and Windows filesystems.

We don't need the BSON.BSONType-1.html file; BSON.bsonType-1.html and BSON.BSONType-2.html are the correct files, and BSON.BSONType-1.html is merely an outdated version of the latter that stuck around from before the addition of lowercase bsonType to the API.

According to our git history, no file from docs/Next has ever been deleted; as a follow-up item, we should probably make sure that when we generate docs, we start out with a fresh, empty directory, instead of only adding new files.

Description

Summary of Changes

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

The fact that we have two files in this directory which only differ
by casing messes up checkouts on case-insensitive filesystems, like
the default macOS and Windows filesystems.

We don't need the `BSON.BSONType-1.html` file; `BSON.bsonType-1.html`
and `BSON.BSONType-2.html` are the correct files, and
`BSON.BSONType-1.html` is merely an outdated version of the latter
that stuck around from before the addition of lowercase `bsonType`
to the API.

According to our git history, no file from `docs/Next` has ever
been deleted; as a follow-up item, we should probably make sure
that when we generate docs, we start out with a fresh, empty
directory, instead of only adding new files.
@addaleax addaleax requested a review from a team as a code owner October 24, 2025 11:56
@tadjik1 tadjik1 self-assigned this Oct 24, 2025
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 24, 2025
@tadjik1 tadjik1 merged commit df3aaaa into main Oct 24, 2025
25 of 27 checks passed
@tadjik1 tadjik1 deleted the fix-bsontype-conflict branch October 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants