Skip to content

Commit 3f3a3c2

Browse files
committed
test(crud): remove result expectation for $out agg test
Drivers are not required to provide a cursor against the collection indicated in a `$out`. The presence of a `result` as well as `collection` fields in this test is inconsistent with the rest of the crud tests, and makes it difficult for implementations to share common code for checking expectations without writing very specific code to check for this isolated case.
1 parent 4e1f8e4 commit 3f3a3c2

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

source/crud/tests/v1/read/aggregate-out.json

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,6 @@
4141
}
4242
},
4343
"outcome": {
44-
"result": [
45-
{
46-
"_id": 2,
47-
"x": 22
48-
},
49-
{
50-
"_id": 3,
51-
"x": 33
52-
}
53-
],
5444
"collection": {
5545
"name": "other_test_collection",
5646
"data": [
@@ -92,16 +82,6 @@
9282
}
9383
},
9484
"outcome": {
95-
"result": [
96-
{
97-
"_id": 2,
98-
"x": 22
99-
},
100-
{
101-
"_id": 3,
102-
"x": 33
103-
}
104-
],
10585
"collection": {
10686
"name": "other_test_collection",
10787
"data": [

source/crud/tests/v1/read/aggregate-out.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ tests:
1818
batchSize: 2
1919

2020
outcome:
21-
# Note: drivers are not required to return a cursor for aggregate
22-
# pipelines using $out, but those that do may use this result to
23-
# assert that the returned cursor points to the output collection.
24-
# Drivers that do not return cursors for $out should ignore this.
25-
result:
26-
- {_id: 2, x: 22}
27-
- {_id: 3, x: 33}
2821
collection:
2922
name: "other_test_collection"
3023
data:
@@ -43,9 +36,6 @@ tests:
4336
batchSize: 0
4437

4538
outcome:
46-
result:
47-
- {_id: 2, x: 22}
48-
- {_id: 3, x: 33}
4939
collection:
5040
name: "other_test_collection"
5141
data:

0 commit comments

Comments
 (0)