check_uptime: Add option to report uptime in days instead of seconds #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could you please add a help entry as well? |
sni
requested changes
Feb 14, 2022
amotl
force-pushed
the
amo/uptime-as-days
branch
2 times, most recently
from
9681e24 to
70a17f8
Compare
|
Dear Sven, thank you for the quick reply. I've just amended this patch according to your suggestions and also added a corresponding test case. Fixing a one-letter typo has been diverted to #1751. With kind regards, |
sni
approved these changes
Feb 15, 2022
plugins-scripts/check_uptime.pl
Outdated
| @@ -262,6 +274,7 @@ () | |||
| print "-c (--critical) = Min. number of uptime to generate critical alert ( w < c )\n"; | |||
| print "-f (--for) = Show uptime in a pretty format (Running for x weeks, x days, ...)\n"; | |||
| print "-s (--since) = Show last boot in yyyy-mm-dd HH:MM:SS format (output from 'uptime -s')\n"; | |||
| print "-s (--days) = Show uptime in days\n"; | |||
There was a problem hiding this comment.
Oh my, it was late at night ;]. Thanks. Fixed!
Currently, the plugin output is: CRITICAL: Uptime is 38829029 seconds. When using the proposed `--days|-d` option, it will be: CRITICAL: Uptime is 449 days.
amotl
force-pushed
the
amo/uptime-as-days
branch
from
70a17f8 to
3b79309
Compare
|
great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear community. Dear @wopfel and @sni.
Firsts things first: Thanks a stack for conceiving and maintaining this excellent collection of monitoring plugins.
This is a humble patch for the
check_uptime.plsensor to make it report the system uptime in days instead of seconds. It has been wired to a new--daysoption, in order not to change its default behavior.The rationale is to reduce mental load for humans, when looking at the textual output of the sensor. While the "pretty" format already implemented by
check_uptime.plhas good intentions, it didn't quite nail it for us.With kind regards,
Andreas.
Previous situation
Currently, the baseline plugin output, with no way to change it, is:
We also tried using both options
--forand--since. However, we still have not been happy with the corresponding output.New situation
When using the proposed
--days|-doption, the output will be:In our opinion, this is much more pleasant.