Bug: AutoWebProxyScriptEngine.InitializeRegistryGlobalProxy

[KevinKeyser]

InitializeRegistryGlobalProxy should not error out if ProxyEnable is true and ProxyServer is null. All other applications and services work when my registry has proxyenabled with no proxyserver key. The only test I tried is when using System.Net.WebRequest.Create() and InitializeRegistryGlobalProxy throws a null object exception which I believe is on this line of code:

mono/mcs/class/System/ReferenceSources/AutoWebProxyScriptEngine.cs

Line 127 in 22c9616

if (strProxyServer.Contains ("=")) {

.

This should get a null check or default value of an empty string e.g. :
1.) set strProxyServer default value to String.Empty or equivalent.
string strProxyServer = (string)Microsoft.Win32.Registry.GetValue ("HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings", "ProxyServer", String.Empty);
2.) null check for strProxyServer could be on the line 127 before checking strProxyServer.Contains("=").

[witcher112]

I can confirm that this issue is real. We are using Unity as a base for our application and one of our users had "ProxyEnable" set to true in his registry, but "ProxyServer" entry was missing. That lead to crash while using HttpWebRequest. I'm attaching a stack trace:

  at System.Net.AutoWebProxyScriptEngine.InitializeRegistryGlobalProxy () [0x0005b] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.AutoWebProxyScriptEngine.GetWebProxyData () [0x00007] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebProxy.UnsafeUpdateFromRegistry () [0x0001a] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebProxy..ctor (System.Boolean enableAutoproxy) [0x0000d] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebProxy.CreateDefaultProxy () [0x00012] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.Configuration.DefaultProxySectionInternal.GetSystemWebProxy () [0x00000] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.Configuration.DefaultProxySectionInternal.GetDefaultProxy_UsingOldMonoCode () [0x00036] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.Configuration.DefaultProxySectionInternal.GetSection () [0x00015] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebRequest.get_InternalDefaultWebProxy () [0x00022] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.HttpWebRequest..ctor (System.Uri uri) [0x0008d] in <3845a180c26b4889bc2d47593a665814>:0 
  at (wrapper remoting-invoke-with-check) System.Net.HttpWebRequest..ctor(System.Uri)
  at System.Net.HttpRequestCreator.Create (System.Uri uri) [0x00000] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebRequest.Create (System.Uri requestUri, System.Boolean useUriBase) [0x00091] in <3845a180c26b4889bc2d47593a665814>:0 
  at System.Net.WebRequest.Create (System.Uri requestUri) [0x00014] in <3845a180c26b4889bc2d47593a665814>:0 
  at PatchKit.Network.DefaultHttpClient.Request (PatchKit.Network.BaseHttpRequest request, System.Action`1[T] tweakMethodSpecific) [0x0004d] in <76072dbeb0ed464c99ae3b2b05a36cb7>:0 
  at PatchKit.Network.DefaultHttpClient.Get (PatchKit.Network.HttpGetRequest getRequest) [0x00014] in <76072dbeb0ed464c99ae3b2b05a36cb7>:0 
  at PatchKit.Unity.Patcher.AppData.Remote.Downloaders.BaseHttpDownloader.Download (PatchKit.Unity.Patcher.Cancellation.CancellationToken cancellationToken) [0x00117] in <429f6f228c784881aeed5c87f323036e>:0 ```

[witcher112]

Pull request has been sent - I've chosen to go with second option:

2.) null check for strProxyServer could be on the line 127 before checking strProxyServer.Contains("=").