Skip to content

Fix: Stop making assumption that bundle might start with 'define(' #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

Fix: Stop making assumption that bundle might start with 'define(' #31

merged 1 commit into from
Dec 18, 2019

Conversation

@morriq
Copy link
Owner

@morriq morriq commented Dec 18, 2019

Bundle might start with comment, like this:

/* Hello, I broke your plugin */
define(

@morriq morriq merged commit d75acb5 into master Dec 18, 2019
@morriq morriq deleted the fix/amd branch December 18, 2019 18:23
morriq pushed a commit that referenced this pull request Dec 18, 2019
@semantic-release-bot
Docs: Release 2.1.1 [skip ci]
41bed84 
## [2.1.1](v2.1.0...v2.1.1) (2019-12-18)

### Fix

* Stop making assumption that bundle might start with 'define(' (#31) ([d75acb5](d75acb5)), closes [#31](#31)
@morriq
Copy link
Owner Author

morriq commented Dec 18, 2019

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@morriq