-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type safety for CartesianInterpolator #1325
Type safety for CartesianInterpolator #1325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice change. It is really helpful when your compiler can help you detect logic errors.
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 61.41% 61.38% -0.03%
==========================================
Files 274 274
Lines 24963 24979 +16
==========================================
+ Hits 15329 15331 +2
- Misses 9634 9648 +14
Continue to review full report at Codecov.
|
(cherry picked from commit 4e97446)
(cherry picked from commit 4e97446)
Description
Overloads of
CartesianInterpolator::computeCartesianPath
may return a distance or a percentage value, while the return type is alwaysdouble
. This PR introduces type safety for these return values.Checklist