Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TrajOpt Default Parameters #1332

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Remove TrajOpt Default Parameters #1332

merged 2 commits into from
Jun 10, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Jun 10, 2022

Description

Since TrajOpt is currently out of service in ROS 2, remove the default parameters from moveit_configs_utils.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@DLu DLu mentioned this pull request Jun 10, 2022
6 tasks
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1332 (670865a) into main (99c73e6) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
+ Coverage   61.41%   61.57%   +0.17%     
==========================================
  Files         274      274              
  Lines       24963    24966       +3     
==========================================
+ Hits        15329    15371      +42     
+ Misses       9634     9595      -39     
Impacted Files Coverage Δ
...mpl_interface/src/model_based_planning_context.cpp 51.51% <100.00%> (+0.30%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.29% <0.00%> (-0.43%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.08% <0.00%> (+0.72%) ⬆️
moveit_core/robot_model/src/joint_model_group.cpp 63.89% <0.00%> (+1.97%) ⬆️
...terface/parameterization/model_based_state_space.h 97.44% <0.00%> (+10.26%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 86.34% <0.00%> (+18.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8429491...670865a. Read the comment docs.

@AndyZe AndyZe merged commit 6cd49c0 into moveit:main Jun 10, 2022
@DLu DLu deleted the remove_trajopt branch June 13, 2022 14:08
pac48 pushed a commit to pac48/moveit2 that referenced this pull request Jun 13, 2022
Co-authored-by: AndyZe <zelenak@picknik.ai>
pac48 pushed a commit to pac48/moveit2 that referenced this pull request Jun 13, 2022
Co-authored-by: AndyZe <zelenak@picknik.ai>
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Co-authored-by: AndyZe <zelenak@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants