Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generate_parameter_library to load ikfast kinematics parameters #1675

Merged
merged 6 commits into from
Nov 1, 2022

Conversation

Abishalini
Copy link
Contributor

Description

Use generate_parameter_library to load ikfast kinematics parameters

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 51.10% // Head: 51.07% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (2bf09d0) compared to base (029a7a9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1675      +/-   ##
==========================================
- Coverage   51.10%   51.07%   -0.03%     
==========================================
  Files         381      381              
  Lines       31743    31743              
==========================================
- Hits        16218    16208      -10     
- Misses      15525    15535      +10     
Impacted Files Coverage Δ
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.45% <0.00%> (-1.49%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 76.78% <0.00%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Abishalini Abishalini force-pushed the ikfast_kinematics_parameters branch 2 times, most recently from 7b621da to cc88e9f Compare October 31, 2022 16:55
@Abishalini Abishalini mentioned this pull request Oct 31, 2022
6 tasks
@tylerjw tylerjw force-pushed the ikfast_kinematics_parameters branch from cc88e9f to 85a6242 Compare October 31, 2022 17:26
@tylerjw tylerjw force-pushed the ikfast_kinematics_parameters branch from bbc8afa to d83ca52 Compare October 31, 2022 22:59
@tylerjw tylerjw merged commit 9ee6623 into moveit:main Nov 1, 2022
@Abishalini Abishalini deleted the ikfast_kinematics_parameters branch November 1, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants