Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale GHA #2022

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add stale GHA #2022

merged 1 commit into from
Mar 17, 2023

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Mar 17, 2023

Enables a stale action that labels issues and PRs as stale after 45 days, and closes issues after another 45 days. The action also takes care about warning the author appropriately, and it ignores a set of persistent labels. The intention of this is to really only keep issues open that are persistent explicitly (there is a new label for that), or that belong to a roadmap, milestone, etc.. All other issues should require at least some activity within the 3 months of time it would take for this GHA to close them.

Fixes #1490

* Issues and PRs are labeled as stale after 45 days.
* Stale issues are closed after another 45 days.
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 16.67% and no project coverage change.

Comparison is base (a27bd6f) 50.91% compared to head (ba1a271) 50.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
- Coverage   50.91%   50.90%   -0.00%     
==========================================
  Files         374      374              
  Lines       31362    31360       -2     
==========================================
- Hits        15964    15961       -3     
- Misses      15398    15399       +1     
Impacted Files Coverage Δ
...rajectory_processing/src/ruckig_traj_smoothing.cpp 60.72% <16.67%> (+1.12%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tylerjw tylerjw merged commit b6693ff into moveit:main Mar 17, 2023
@v4hn
Copy link
Contributor

v4hn commented Mar 19, 2023

I still think this is superficial make-up and the only thing it does is add bloat where maintainer actions are required.
An issue list (even when the issues age) is a valuable resource of user input, not a junkyard that needs automatic discarding. In an ideal world all items in it warrant a manually added "can't reproduce/not enough information/won't fix" label before they are closed without a merged patch.

I guess you weakened the conditions enough to avoid further complains.

@AndyZe
Copy link
Member

AndyZe commented Mar 20, 2023

I thought discussions were supposed to go in the Discussions tab that was the cool new thing a couple months ago ;)

This type of shuffling of deck chairs amuses me. I hope no valuable old issues get lost because of it.

@henningkayser
Copy link
Member Author

henningkayser commented Mar 23, 2023

Same response as here #1490 (comment).

I still think this is superficial make-up

yes

and the only thing it does is add bloat where maintainer actions are required

it automates superficial maintainer actions

An issue list (even when the issues age) is a valuable resource of user input, not a junkyard

it's both

that needs automatic discarding

it doesn't, but it helps

In an ideal world

...

all items in it warrant a manually added "can't reproduce/not enough information/won't fix" label before they are closed without a merged patch.

We do have that and use it frequently

I guess you weakened the conditions enough to avoid further complains.

I hope so. My concern is really not about rejecting valuable issues. It's about requiring people to think about the content and value of their issue first before posting it in the first place. There is a huge amount of content that is along the lines of "we could...", "it would be nice..." that no one ever responds to because it's apparently not important at all. If only all maintainers would post issues of whatever wishes or concerns they have about the code base, the list would be endless and it would still be just as useless. Let's focus on actual problems and action items that are important enough to discuss them.

I thought discussions were supposed to go in the Discussions tab that was the cool new thing a couple months ago ;)

GitHub discussions are obviously something different than issues but it's hard to argue that issues are not meant for discussions.

btw, if anyone thinks that their issue is important enough to stay up forever, they can use the persistent label

abhijelly added a commit to abhijelly/moveit2 that referenced this pull request Apr 9, 2023
Increase priority for constrained planning state space (moveit#1300)

* Change priority for the constrained planning state space

* Fix constrained planning tests

* Use PRM instead of RRTConnect

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>

Remove "new" from smart pointer instantiation (moveit#2019)

Temporarily disable TestPathConstraints with the Panda robot (moveit#2016)

This test has become flaky since it was modified to use the OMPL constrained state space (moveit#2015).

Fix mimic joints with TOTG (moveit#1989)

Fix include install destination (moveit#2008)

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>

Ruckig-smoothing : reduce number of  duration extensions (moveit#1990)

* extend duration only for failed segment

* update comment

* Remove trajectory reset before extension

* readability improvement

* Remove call to RobotState update

---------

Co-authored-by: ibrahiminfinite <ibrahimjkd@@gmail.com>
Co-authored-by: AndyZe <andyz@utexas.edu>

Add stale GHA (moveit#2022)

* Issues and PRs are labeled as stale after 45 days.
* Stale issues are closed after another 45 days.

Enable workflow_dispatch for stale GHA

Remove invalid description field in GHA

Add callback for velocity scaling override + fix params namespace not being set (moveit#2021)

Fix python tests (moveit#1979)

* ensure joint models in robot_model submodule

* add build tests

Upgrade apt dependencies --with-new-pkgs (moveit#2039)

2.7.1

🛠️ Bump actions/stale from 7 to 8 (moveit#2037)

Allow ci-testing Dockerfile to update the ROS_DISTRO (moveit#2035)

Move displaced launch file into planning_component_tools (moveit#2044)

Delete the Ruckig "batches" option, deprecated by moveit#1990 (moveit#2028)

Added set_robot_trajectory_msg to python bindings (moveit#2050)

Use $DISPLAY rather than assuming :0 (moveit#2049)

* Use $DISPLAY rather than assuming :

* Double quotes

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>

Optionally mitigate Ruckig overshoot (moveit#2051)

* Optionally mitigate Ruckig overshoot

* Cleanup

Update description of moveit_ros_planning_interface (moveit#2045)

* Update description of moveit_ros_planning_interface

* Update moveit_ros/planning_interface/package.xml

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>

---------

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>

Add URDF Loader Exceptions and Fix Infinite While-Loop when URDF file isn't in a ROS Package (moveit#2032)

* Fixed infinite while loop in utilities.cpp and added some exception handling to start screen widget

* Fix trailing whitespace, fix getSharePath exception catch on empty request

* Fix clang tidy suggestion and error message updates based on pr comments

[hybrid planning] improve planning scene monitoring (moveit#1090)

* Create new PSM in local constraint solver. Different type of collision checking.

* Small boolean logic fixup

* Don't configure planning scene monitor twice and pass scene as const

* Remove not required call of updateSceneWithCurrentState()

* Revert PlanningSceneMonitorConstPtr to PlanningSceneMonitorPtr

* Set planning_scene_monitor update rate

* Decrease planning scene update rate

* Use `updateSceneWithCurrentState()` in psm

* Revert the manner of collision checking

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>

Document how collision checking includes descendent links (moveit#2058)

Move stateless PlanningScene helper functions out of the class (moveit#2025)

Readability: kinematic_state -> robot_state (moveit#2078)

moveit_py citation (moveit#2029)

Extract parallel planning from moveit cpp (moveit#2043)

* Add parallel_planning_interface

* Add parallel planning interface

* Rename package to pipeline_planning_interface

* Move plan_responses_container into own header + source file

* Add plan_responses_contrainer source file

* Add solution selection and stopping criterion function files

* Remove parallel planning from moveit_cpp

* Move parallel planning into planning package

* Update moveit_cpp

* Drop planning_interface changes

* Add documentation

* Update other moveit packages

* Remove removed header

* Address CI complains

* Address clang-tidy complains

* Address clang-tidy complains 2

* Address clang-tidy complains 3

* Extract planning pipeline map creation function from moveit_cpp

* Cleanup comment

* Use const moveit::core::RobotModelConstPtr&

* Formatting

* Add header descriptions

* Remove superfluous TODOs

* Cleanup

PILZ: Throw if IK solver doesn't exist (moveit#2082)

* Throw if IK solver doesn't exist

* Format

enabled -wformat (moveit#2065)

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>

Add test and debug issue where TOTG returns accels > limit (moveit#2084)

lint fix

lint fix 1

lint fix 2

lint fix 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale bot for PRs
4 participants