Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added full stops #2487

Merged
merged 1 commit into from
Oct 25, 2023
Merged

added full stops #2487

merged 1 commit into from
Oct 25, 2023

Conversation

bhargavshirin
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable
I have added full stops to make sure sentence is completed

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@bhargavshirin
added full stops
d0d503e 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b621d7) 50.77% compared to head (d0d503e) 50.38%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   50.77%   50.38%   -0.38%     
==========================================
  Files         392      391       -1     
  Lines       32125    31954     -171     
==========================================
- Hits        16307    16097     -210     
- Misses      15818    15857      +39
Files Coverage Δ
.../moveit_core/robot_trajectory/robot_trajectory.cpp 77.15% <ø> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjw tylerjw merged commit 7fba8c6 into moveit:main Oct 25, 2023
12 checks passed
@tylerjw tylerjw added backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Oct 25, 2023
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@bhargavshirin @mergify
added full stops (#2487)
158ad0c 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)

# Conflicts:
#	README.md
@mergify mergify bot mentioned this pull request Oct 25, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@bhargavshirin @mergify
added full stops (#2487)
d1be57a 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)

# Conflicts:
#	README.md
@mergify mergify bot mentioned this pull request Oct 25, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@bhargavshirin @mergify
added full stops (#2487)
082fc5c 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@bhargavshirin @mergify
added full stops (#2487)
218733b 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
tylerjw pushed a commit that referenced this pull request Oct 25, 2023
@mergify @bhargavshirin
added full stops (#2487) (#2491)
2ee72ae 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)

Co-authored-by: Bhargav Shirin Nalamati <bnalamat@gitam.in>
tylerjw pushed a commit that referenced this pull request Oct 25, 2023
@mergify @bhargavshirin
added full stops (#2487) (#2490)
3144e6e 
Signed-off-by: bhargavshirin <bnalamat@gitam.in>
(cherry picked from commit 7fba8c6)

Co-authored-by: Bhargav Shirin Nalamati <bnalamat@gitam.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

Assignees
No one assigned
Labels
backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhargavshirin @tylerjw