-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean OpenSSL dependencies #514
Conversation
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 45.17% 45.23% +0.06%
==========================================
Files 169 169
Lines 18734 18723 -11
==========================================
+ Hits 8462 8468 +6
+ Misses 10272 10255 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where libssl-dev
is being used in moveit_ros_warehouse
, I think the solution should be to remove OpenSSl from CMakeLists.txt, ${OPENSSL_INCLUDE_DIR}, and target_link_libraries
This will fail until moveit/warehouse_ros#80 is merged. prerelease failure turned out to be a warehouse_ros export issue. We will now need to get a new Rolling and Galactic release for |
I merged the PR in warehouse_ros and re-triggered all the CI jobs for this PR. |
Thanks! Foxy and Rolling CIs doesn't seem re-triggered for me though 🤔. Can you check that @tylerjw ? |
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
prerelease on Rolling was failing in my fork with current master with SSL errors: https://github.com/vatanaksoytezer/moveit2/runs/2909420963?check_suite_focus=true
I just applied the same solution with moveit/warehouse_ros_mongo#63. Now I can confirm that pre-release is passing on Rolling https://github.com/vatanaksoytezer/moveit2/runs/2909699212?check_suite_focus=true.
Galactic prerelease still fails because of geometric shapes failing on Galactic in buildfarm due to a bloom issue I suppose (see https://build.ros2.org/job/Gsrc_uF__geometric_shapes__ubuntu_focal__source/12/console)