Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean OpenSSL dependencies #514

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

vatanaksoytezer
Copy link
Contributor

prerelease on Rolling was failing in my fork with current master with SSL errors: https://github.com/vatanaksoytezer/moveit2/runs/2909420963?check_suite_focus=true

I just applied the same solution with moveit/warehouse_ros_mongo#63. Now I can confirm that pre-release is passing on Rolling https://github.com/vatanaksoytezer/moveit2/runs/2909699212?check_suite_focus=true.

Galactic prerelease still fails because of geometric shapes failing on Galactic in buildfarm due to a bloom issue I suppose (see https://build.ros2.org/job/Gsrc_uF__geometric_shapes__ubuntu_focal__source/12/console)

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #514 (bd012c3) into main (68b2dc3) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   45.17%   45.23%   +0.06%     
==========================================
  Files         169      169              
  Lines       18734    18723      -11     
==========================================
+ Hits         8462     8468       +6     
+ Misses      10272    10255      -17     
Impacted Files Coverage Δ
...bot_model/include/moveit/robot_model/robot_model.h 86.67% <0.00%> (-6.19%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 74.15% <0.00%> (-0.54%) ⬇️
.../collision_detection_fcl/src/collision_env_fcl.cpp 89.64% <0.00%> (-0.36%) ⬇️
moveit_core/robot_model/src/robot_model.cpp 72.94% <0.00%> (-0.05%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 28.94% <0.00%> (-0.04%) ⬇️
moveit_ros/moveit_servo/src/servo_calcs.cpp 0.00% <0.00%> (ø)
moveit_core/kinematic_constraints/src/utils.cpp 10.00% <0.00%> (ø)
...ccupancy_map_monitor/src/occupancy_map_updater.cpp 0.00% <0.00%> (ø)
...mpl_interface/src/model_based_planning_context.cpp 48.98% <0.00%> (ø)
...anning_scene_monitor/src/current_state_monitor.cpp 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b2dc3...bd012c3. Read the comment docs.

Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where libssl-dev is being used in moveit_ros_warehouse, I think the solution should be to remove OpenSSl from CMakeLists.txt, ${OPENSSL_INCLUDE_DIR}, and target_link_libraries

@vatanaksoytezer vatanaksoytezer changed the title [rolling-prerelease] Add openssl as build depend Clean OpenSSL dependencies Jun 25, 2021
@vatanaksoytezer
Copy link
Contributor Author

This will fail until moveit/warehouse_ros#80 is merged. prerelease failure turned out to be a warehouse_ros export issue. We will now need to get a new Rolling and Galactic release for warehouse_ros to pass prerelease tests.

@tylerjw
Copy link
Member

tylerjw commented Jun 28, 2021

I merged the PR in warehouse_ros and re-triggered all the CI jobs for this PR.

@vatanaksoytezer
Copy link
Contributor Author

I merged the PR in warehouse_ros and re-triggered all the CI jobs for this PR.

Thanks! Foxy and Rolling CIs doesn't seem re-triggered for me though 🤔. Can you check that @tylerjw ?

@henningkayser henningkayser merged commit 53d0a3e into moveit:main Jun 28, 2021
henningkayser added a commit to henningkayser/moveit2 that referenced this pull request Jun 29, 2021
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants