Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor panda demo.launch to use moveit_configs_utils #119

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Mar 11, 2022

Refactor the panda launch file to use moveit_configs_utils

Should resolve the launch portion of #115 for the panda

@stephanie-eng stephanie-eng changed the title WIP: Refactor panda demo.launch to use moveit_configs_utils Refactor panda demo.launch to use moveit_configs_utils Mar 11, 2022
@stephanie-eng stephanie-eng marked this pull request as ready for review March 11, 2022 21:06
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anybody else see a crash when adding the MoveIt Motion Planning plugin to RViz? Also, I see an error about active joints for group hand.

ros2 launch moveit_resources_panda_moveit_config demo.launch.py

[rviz2-1] [INFO] [1648392458.904987286] [moveit_ros_robot_interaction.robot_interaction]: No active joints or end effectors found for group 'hand'. Make sure that kinematics.yaml is loaded in this node's namespace.
[rviz2-1] /opt/ros/rolling/lib/rviz2/rviz2: symbol lookup error: /home/andy/ws_ros2/install/moveit_ros_visualization/lib/libmoveit_motion_planning_rviz_plugin_core.so.2.4.0: undefined symbol: _ZNK14planning_scene13PlanningScene17getCollidingPairsERSt3mapISt4pairINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES8_ESt6vectorIN19collision_detection7ContactESaISC_EESt4lessIS9_ESaIS2_IKS9_SE_EEERKN6moveit4core10RobotStateERKNSB_22AllowedCollisionMatrixE

(Blocking the merge until this is resolved)

@AndyZe
Copy link
Member

AndyZe commented Mar 27, 2022

I also see some issues on main branch. This PR may not be the cause.

@AndyZe
Copy link
Member

AndyZe commented Mar 27, 2022

If we can get this issue fixed, I think it will resolve the issue I see here: moveit/moveit2#1143

@AndyZe
Copy link
Member

AndyZe commented Mar 29, 2022

After updating my ros2_control repos and purging all moveit binaries, this works well 👍 (sudo apt remove ros-rolling-moveit*)

Let's see if we can trim away any unnecessary code, then I'll approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants