Skip to content

Commit 00a4d60

Browse files
committed
Revert "Bug 1948415 - Create a moz-page-header component r=fluent-reviewers,desktop-theme-reviewers,mstriemer,bolsson,dao" for causing mochitest failures @ test_moz_page_header.html This reverts commit cac284b.
1 parent 570bd13 commit 00a4d60

File tree

14 files changed

+39
-486
lines changed

14 files changed

+39
-486
lines changed

browser/components/preferences/preferences.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ function srdSectionEnabled(section) {
168168
const CONFIG_PANES = {
169169
containers2: {
170170
parent: "general",
171-
l10nId: "containers-section-header",
171+
l10nId: "containers-header",
172172
groupIds: ["containers"],
173173
},
174174
};

browser/components/preferences/widgets/setting-pane/setting-pane.mjs

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,18 @@ export class SettingPane extends MozLitElement {
2020
window.gotoPref(this.config.parent);
2121
}
2222

23+
backButtonTemplate() {
24+
if (!this.isSubPane) {
25+
return "";
26+
}
27+
return html`<moz-button
28+
type="icon"
29+
title="Go back"
30+
iconsrc="chrome://global/skin/icons/arrow-left.svg"
31+
@click=${this.goBack}
32+
></moz-button>`;
33+
}
34+
2335
connectedCallback() {
2436
super.connectedCallback();
2537
this.setAttribute("data-category", this.name);
@@ -56,11 +68,10 @@ export class SettingPane extends MozLitElement {
5668

5769
render() {
5870
return html`
59-
<moz-page-header
60-
data-l10n-id=${this.config.l10nId}
61-
.backButton=${this.isSubPane}
62-
@navigate-back=${this.goBack}
63-
></moz-page-header>
71+
<div class="page-header">
72+
${this.backButtonTemplate()}
73+
<h2 data-l10n-id=${this.config.l10nId}></h2>
74+
</div>
6475
${this.config.groupIds.map(groupId => this.groupTemplate(groupId))}
6576
`;
6677
}

browser/locales/en-US/browser/preferences/preferences.ftl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -896,8 +896,6 @@ remove-addon-engine-alert = To remove this search engine, remove the associated
896896
containers-back-button2 =
897897
.aria-label = Back to Settings
898898
containers-header = Container Tabs
899-
containers-section-header =
900-
.heading = Container Tabs
901899
containers-add-button =
902900
.label = Add New Container
903901
.accesskey = A

browser/themes/shared/preferences/preferences.css

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1479,3 +1479,22 @@ richlistitem .text-link:hover {
14791479
font-size: var(--font-size-small);
14801480
}
14811481
}
1482+
1483+
/* START SRD temp page header styles (bug 1948415) */
1484+
.page-header {
1485+
gap: var(--space-small);
1486+
align-items: center;
1487+
1488+
&:not([hidden]) {
1489+
display: flex;
1490+
}
1491+
1492+
> h2 {
1493+
margin: 0;
1494+
}
1495+
1496+
> moz-button:first-of-type:dir(rtl) {
1497+
scale: -1 1;
1498+
}
1499+
}
1500+
/* END SRD temp page header styles (bug 1948415) */

python/l10n/fluent_migrations/bug_1948415_containers_header_migration.py

Lines changed: 0 additions & 23 deletions
This file was deleted.

toolkit/content/customElements.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -851,13 +851,9 @@
851851
"moz-message-bar",
852852
"chrome://global/content/elements/moz-message-bar.mjs",
853853
],
854+
["moz-promo", "chrome://global/content/elements/moz-promo.mjs"],
854855
["moz-option", "chrome://global/content/elements/moz-select.mjs"],
855-
[
856-
"moz-page-header",
857-
"chrome://global/content/elements/moz-page-header.mjs",
858-
],
859856
["moz-page-nav", "chrome://global/content/elements/moz-page-nav.mjs"],
860-
["moz-promo", "chrome://global/content/elements/moz-promo.mjs"],
861857
["moz-radio", "chrome://global/content/elements/moz-radio-group.mjs"],
862858
[
863859
"moz-radio-group",

toolkit/content/jar.mn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ toolkit.jar:
129129
content/global/elements/moz-input-search.mjs (widgets/moz-input-search/moz-input-search.mjs)
130130
content/global/elements/moz-input-text.css (widgets/moz-input-text/moz-input-text.css)
131131
content/global/elements/moz-input-text.mjs (widgets/moz-input-text/moz-input-text.mjs)
132-
content/global/elements/moz-page-header.css (widgets/moz-page-header/moz-page-header.css)
133-
content/global/elements/moz-page-header.mjs (widgets/moz-page-header/moz-page-header.mjs)
134132
content/global/elements/moz-page-nav.css (widgets/moz-page-nav/moz-page-nav.css)
135133
content/global/elements/moz-page-nav-button.css (widgets/moz-page-nav/moz-page-nav-button.css)
136134
content/global/elements/moz-page-nav.mjs (widgets/moz-page-nav/moz-page-nav.mjs)

toolkit/content/tests/widgets/chrome.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ skip-if = ["os == 'mac' && os_version == '14.70' && processor == 'x86_64'"] # Bu
6464

6565
["test_moz_message_bar.html"]
6666

67-
["test_moz_page_header.html"]
68-
6967
["test_moz_page_nav.html"]
7068

7169
["test_moz_promo.html"]

toolkit/content/tests/widgets/test_moz_page_header.html

Lines changed: 0 additions & 185 deletions
This file was deleted.

toolkit/content/widgets/moz-breadcrumb-group/moz-breadcrumb-group.stories.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ moz-breadcrumb-third =
2121
},
2222
};
2323

24-
const Template = ({ l10nId, width, slot }) => {
24+
const Template = ({ l10nId, width }) => {
2525
return html`
2626
<style>
2727
${width
@@ -31,7 +31,7 @@ const Template = ({ l10nId, width, slot }) => {
3131
}`
3232
: ""}
3333
</style>
34-
<moz-breadcrumb-group slot=${ifDefined(slot)}>
34+
<moz-breadcrumb-group>
3535
<moz-breadcrumb
3636
href="about#firstpage"
3737
data-l10n-id=${ifDefined(l10nId + "-first")}

0 commit comments

Comments
 (0)