Skip to content

Commit 0769179

Browse files
committed
Revert "Bug 1898356 - go back one page arrow (button) turns grey after clearing browsing & download history. r=hsohaney" for causing bc failures @ browser_purgehistory_clears_sh.js
This reverts commit 54aaf25.
1 parent 7168886 commit 0769179

File tree

3 files changed

+2
-75
lines changed

3 files changed

+2
-75
lines changed

browser/base/content/browser.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,21 +1025,16 @@ const gClickAndHoldListenersOnElement = {
10251025
},
10261026
};
10271027

1028-
// See bug 1898356 - Navigation buttons aren't being properly disabled
1029-
// when clearing the history. This is due that this callback is called
1030-
// before the panel is closed. By setting "wasdisabled" attribute instead
1031-
// of "disabled" attribute, we are sort of "lying" to `_updateMenuAndCommandState`
1032-
// that they where previously disabled, so it will not enable them.
10331028
const gSessionHistoryObserver = {
10341029
observe(subject, topic) {
10351030
if (topic != "browser:purge-session-history") {
10361031
return;
10371032
}
10381033

10391034
var backCommand = document.getElementById("Browser:Back");
1040-
backCommand.setAttribute("wasdisabled", "true");
1035+
backCommand.setAttribute("disabled", "true");
10411036
var fwdCommand = document.getElementById("Browser:Forward");
1042-
fwdCommand.setAttribute("wasdisabled", "true");
1037+
fwdCommand.setAttribute("disabled", "true");
10431038

10441039
// Clear undo history of the URL bar
10451040
gURLBar.editor.clearUndoRedo();

browser/base/content/test/backforward/browser.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,3 @@
33
["browser_history_menu.js"]
44
fail-if = ["a11y_checks"] # Bug 1854233 navigator-toolbox may not be focusable
55
https_first_disabled = true
6-
7-
["browser_history_menu_clear.js"]

browser/base/content/test/backforward/browser_history_menu_clear.js

Lines changed: 0 additions & 66 deletions
This file was deleted.

0 commit comments

Comments
 (0)