Skip to content

Commit 3faeef4

Browse files
committed
Bug 1973366 - Part 2: Remove unused homeFragment parameter in HomeMenuView r=android-reviewers,devota
Differential Revision: https://phabricator.services.mozilla.com/D254621
1 parent 5fdb88b commit 3faeef4

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import org.mozilla.fenix.GleanMetrics.HomeMenu as HomeMenuMetrics
3939
* @param lifecycleOwner [LifecycleOwner] for the view.
4040
* @param homeActivity [HomeActivity] used to open URLs in a new tab.
4141
* @param navController [NavController] used for navigation.
42-
* @param homeFragment [HomeFragment] used to attach the biometric prompt.
4342
* @param menuButton The [MenuButton] that will be used to create a menu when the button is
4443
* clicked.
4544
* @param fxaEntrypoint The source entry point to FxA.
@@ -50,7 +49,6 @@ class HomeMenuView(
5049
private val lifecycleOwner: LifecycleOwner,
5150
private val homeActivity: HomeActivity,
5251
private val navController: NavController,
53-
private val homeFragment: HomeFragment,
5452
private val menuButton: WeakReference<MenuButton>,
5553
private val fxaEntrypoint: FxAEntryPoint = FenixFxAEntryPoint.HomeMenu,
5654
) {

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/toolbar/HomeToolbarView.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ internal class HomeToolbarView(
158158
lifecycleOwner = homeFragment.viewLifecycleOwner,
159159
homeActivity = homeActivity,
160160
navController = homeFragment.findNavController(),
161-
homeFragment = homeFragment,
162161
menuButton = WeakReference(toolbarBinding.menuButton),
163162
).also { it.build() }
164163

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/HomeMenuViewTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ class HomeMenuViewTest {
4444
private lateinit var view: View
4545
private lateinit var lifecycleOwner: LifecycleOwner
4646
private lateinit var homeActivity: HomeActivity
47-
private lateinit var homeFragment: HomeFragment
4847
private lateinit var navController: NavController
4948
private lateinit var menuButton: MenuButton
5049
private lateinit var homeMenuView: HomeMenuView
@@ -54,7 +53,6 @@ class HomeMenuViewTest {
5453
view = mockk(relaxed = true)
5554
lifecycleOwner = mockk(relaxed = true)
5655
homeActivity = mockk(relaxed = true)
57-
homeFragment = mockk(relaxed = true)
5856
navController = mockk(relaxed = true)
5957

6058
menuButton = spyk(MenuButton(testContext))
@@ -64,7 +62,6 @@ class HomeMenuViewTest {
6462
lifecycleOwner = lifecycleOwner,
6563
homeActivity = homeActivity,
6664
navController = navController,
67-
homeFragment = homeFragment,
6865
menuButton = WeakReference(menuButton),
6966
)
7067
}

0 commit comments

Comments
 (0)