Skip to content

Commit 874e87e

Browse files
committed
Bug 1994855 - Remove assert that doesn't hold. r=win-reviewers,handyman
This spike probably comes from bug 1933181, but that assert is wrong afaict. It's not flushing and we're now creating the widget a bit later, so there might be a popupframe without a widget more often. Looking at the commit that introduced these, it wasn't clear these asserts were correct to begin with. https://hg-edge.mozilla.org/mozilla-central/rev/5823cb0f699866c8672cce50cf8e1cbceadc43aa I think the assert below (every widget hanging from a popup having an hwnd) should hold. Differential Revision: https://phabricator.services.mozilla.com/D268958
1 parent b160781 commit 874e87e

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

widget/windows/SystemStatusBar.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,7 @@ LRESULT StatusBarEntry::OnMessage(HWND hWnd, UINT msg, WPARAM wp, LPARAM lp) {
186186
}
187187

188188
nsIWidget* widget = popupFrame->GetNearestWidget();
189-
MOZ_DIAGNOSTIC_ASSERT(widget);
190-
if (!widget) {
189+
if (NS_WARN_IF(!widget)) {
191190
return TRUE;
192191
}
193192

0 commit comments

Comments
 (0)