Bug 1980967 - Handle iframes going away when firing navigate event. r=jjaschke,smaug

Differential Revision: https://phabricator.services.mozilla.com/D259825

Author: farre

dom/navigation/Navigation.cpp

@@ -891,6 +891,8 @@ bool Navigation::InnerFireNavigateEvent(
     already_AddRefed<FormData> aFormDataEntryList,
     nsIStructuredCloneContainer* aClassicHistoryAPIState,
     const nsAString& aDownloadRequestFilename) {
+  nsCOMPtr<nsIGlobalObject> globalObject = GetOwnerGlobal();
+
   // Step 1
   if (HasEntriesAndEventsDisabled()) {
     // Step 1.1 to step 1.3
@@ -971,8 +973,7 @@ bool Navigation::InnerFireNavigateEvent(
   init.mSourceElement = aSourceElement;
 
   // Step 19
-  RefPtr<AbortController> abortController =
-      new AbortController(GetOwnerGlobal());
+  RefPtr<AbortController> abortController = new AbortController(globalObject);
 
   // Step 20
   init.mSignal = abortController->Signal();
@@ -1052,9 +1053,9 @@ bool Navigation::InnerFireNavigateEvent(
     MOZ_DIAGNOSTIC_ASSERT(fromNHE);
 
     // Step 33.4
-    RefPtr<Promise> promise = Promise::CreateInfallible(GetOwnerGlobal());
+    RefPtr<Promise> promise = Promise::CreateInfallible(globalObject);
     mTransition = MakeAndAddRef<NavigationTransition>(
-        GetOwnerGlobal(), aNavigationType, fromNHE, promise);
+        globalObject, aNavigationType, fromNHE, promise);
 
     // Step 33.5
     MOZ_ALWAYS_TRUE(promise->SetAnyPromiseIsHandled());
@@ -1094,17 +1095,22 @@ bool Navigation::InnerFireNavigateEvent(
     // Step 34.2
     for (auto& handler : event->NavigationHandlerList().Clone()) {
       // Step 34.2.1
-      promiseList.AppendElement(MOZ_KnownLive(handler)->Call());
+      RefPtr promise = MOZ_KnownLive(handler)->Call();
+      if (promise) {
+        promiseList.AppendElement(promise);
+      }
     }
 
     // Step 34.3
     if (promiseList.IsEmpty()) {
-      promiseList.AppendElement(Promise::CreateResolvedWithUndefined(
-          GetOwnerGlobal(), IgnoredErrorResult()));
+      RefPtr promise = Promise::CreateResolvedWithUndefined(
+          globalObject, IgnoredErrorResult());
+      if (promise) {
+        promiseList.AppendElement(promise);
+      }
     }
 
     // Step 34.4
-    nsCOMPtr<nsIGlobalObject> globalObject = GetOwnerGlobal();
     // We capture the scope which we wish to keep alive in the lambdas passed to
     // Promise::WaitForAll. We pass it as the cycle collected argument to
     // Promise::WaitForAll, which makes it stay alive until all promises
@@ -1310,7 +1316,9 @@ void Navigation::AbortOngoingNavigation(JSContext* aCx,
 
   // Step 6
   if (event->IsBeingDispatched()) {
-    event->PreventDefault();
+    // Here NonSystem is needed since it needs to be the same as what we
+    // dispatch with.
+    event->PreventDefault(aCx, CallerType::NonSystem);
   }
 
   // Step 7