Bug 1720570 - Move ModuleTypeAllowed check into ModuleLoaderBase; r=allstarschh

CSS Modules are not supported in Workers and Worklets. This adds a
IsModuleTypeAllowed to ModuleLoaderBase so that the subclasses can
decide which modules are allowed.

Differential Revision: https://phabricator.services.mozilla.com/D263412

Author: dminor

js/loader/ModuleLoaderBase.cpp

@@ -101,10 +101,6 @@ void ModuleLoaderBase::EnsureModuleHooksInitialized() {
                                  HostReleaseTopLevelScript);
 }
 
-static bool ModuleTypeAllowed(ModuleType aModuleType) {
-  return aModuleType != ModuleType::Unknown;
-}
-
 static bool CreateBadModuleTypeError(JSContext* aCx, LoadedScript* aScript,
                                      nsIURI* aURI,
                                      MutableHandle<Value> aErrorOut) {
@@ -219,7 +215,7 @@ bool ModuleLoaderBase::HostLoadImportedModule(JSContext* aCx,
     MOZ_ASSERT(uri, "Failed to resolve module specifier");
 
     ModuleType moduleType = GetModuleRequestType(aCx, aModuleRequest);
-    if (!ModuleTypeAllowed(moduleType)) {
+    if (!loader->IsModuleTypeAllowed(moduleType)) {
       LOG(("ModuleLoaderBase::HostLoadImportedModule uri %s, bad module type",
            uri->GetSpecOrDefault().get()));
       Rooted<Value> error(aCx);

js/loader/ModuleLoaderBase.h

@@ -421,6 +421,10 @@ class ModuleLoaderBase : public nsISupports {
   // https://html.spec.whatwg.org/multipage/webappapis.html#disallow-further-import-maps
   void DisallowImportMaps() { mImportMapsAllowed = false; }
 
+  virtual bool IsModuleTypeAllowed(ModuleType aModuleType) {
+    return aModuleType != ModuleType::Unknown;
+  }
+
   // Returns whether there has been an entry in the import map
   // for the given aURI.
   bool GetImportMapSRI(nsIURI* aURI, nsIURI* aSourceURI,