Bug 1977670 - Part 1 - Remove window insets padding from TopAppBar Composables r=android-reviewers,matt-tighe

There seems to be some weirdness with the M3 TopAppBar and Edge to Edge, causing the TopAppBar to have increased margins. I was not able to reproduce this visual bug on older Android OS versions though, which would make sense, if this were due to Edge to Edge.

Default window inset values:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt;l=441

Affected screens:
- Logins (fixed in Bug 1975375)
- Bookmarks
- Downloads
- Debug Drawer
- Web Compat Reporter
- Glean Debug Tools

Part 2 will handle the recoloring of the app bar when the content has scrolled

Differential Revision: https://phabricator.services.mozilla.com/D257596

Author: MozillaNoah

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/debugsettings/gleandebugtools/GleanDebugToolsFragment.kt

@@ -6,6 +6,7 @@ package org.mozilla.fenix.debugsettings.gleandebugtools
 
 import android.content.Intent
 import android.widget.Toast
+import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.Icon
@@ -18,6 +19,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.unit.dp
 import androidx.core.net.toUri
 import androidx.navigation.fragment.findNavController
 import mozilla.telemetry.glean.Glean
@@ -90,6 +92,10 @@ class GleanDebugToolsFragment : ComposeFragment() {
                                 )
                             }
                         },
+                        windowInsets = WindowInsets(
+                            top = 0.dp,
+                            bottom = 0.dp,
+                        ),
                         colors = TopAppBarDefaults.topAppBarColors(containerColor = FirefoxTheme.colors.layer1),
                     )
                 },

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/debugsettings/ui/DebugDrawer.kt

@@ -6,6 +6,7 @@ package org.mozilla.fenix.debugsettings.ui
 
 import androidx.compose.foundation.background
 import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.ExperimentalMaterial3Api
@@ -79,6 +80,10 @@ fun DebugDrawer(
                         }
                     }
                 },
+                windowInsets = WindowInsets(
+                    top = 0.dp,
+                    bottom = 0.dp,
+                ),
                 colors = TopAppBarDefaults.topAppBarColors(containerColor = FirefoxTheme.colors.layer1),
             )
         },

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/downloads/listscreen/DownloadsTopAppBar.kt

@@ -4,6 +4,7 @@
 
 package org.mozilla.fenix.downloads.listscreen
 
+import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.Icon
 import androidx.compose.material3.IconButton
@@ -15,6 +16,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.unit.dp
 import mozilla.components.compose.base.annotation.FlexibleWindowLightDarkPreview
 import org.mozilla.fenix.R
 import org.mozilla.fenix.theme.FirefoxTheme
@@ -47,6 +49,10 @@ internal fun DownloadsTopAppBar(
         actions = {
             actions()
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
         colors = TopAppBarDefaults.topAppBarColors(containerColor = backgroundColor),
     )
 }

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/ui/BookmarksScreen.kt

@@ -705,6 +705,10 @@ private fun BookmarksListTopBar(
                     }
                 }
             },
+            windowInsets = WindowInsets(
+                top = 0.dp,
+                bottom = 0.dp,
+            ),
         )
     }
 }
@@ -901,6 +905,10 @@ private fun SelectFolderTopBar(
                 }
             }
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
     )
 }
 
@@ -1243,6 +1251,10 @@ private fun EditFolderTopBar(
                 )
             }
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
     )
 }
 
@@ -1322,6 +1334,10 @@ private fun AddFolderTopBar(onBackClick: () -> Unit) {
                 )
             }
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
     )
 }
 
@@ -1510,6 +1526,10 @@ private fun EditBookmarkTopBar(
                 )
             }
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
     )
 }
 

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/ui/WebCompatReporter.kt

@@ -10,6 +10,7 @@ import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
+import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.imePadding
@@ -279,6 +280,10 @@ private fun TempAppBar(
                 )
             }
         },
+        windowInsets = WindowInsets(
+            top = 0.dp,
+            bottom = 0.dp,
+        ),
     )
 }