This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #18163: Use SyncedTabsFacts for Synced Tab Telemetry #18172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketsroger
added
needs:data-review
PR is awaiting a data review
needs:review
PRs that need to be reviewed
labels
Feb 25, 2021
Request for data collection review
|
rocketsroger
force-pushed
the
FB_18163
branch
2 times, most recently
from
February 25, 2021 14:57
a1c9198
to
f2d5fa5
Compare
This pull request has conflicts when rebasing. Could you fix it @rocketsroger? 🙏 |
eliserichards
approved these changes
Mar 3, 2021
@@ -85,4 +86,11 @@ class GleanMetricsServiceTest { | |||
assertEquals(1, events[0].extra!!.size) | |||
assertEquals("APP_ICON", events[0].extra!!["source"]) | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 yay tests!
@@ -227,4 +227,18 @@ class MetricControllerTest { | |||
|
|||
assertEquals(controller.factToEvent(fact), Event.HaveNoTopSites) | |||
} | |||
|
|||
@Test | |||
fun `tracking synced tab event should be sent to enabled service`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Data Review
Yes, via the metrics.md and other Glean tools.
Yes
Not applicable, the collection is set to end 2021-08-01.
Category 2, User Interaction
Default on
No
Yes
No, unless the owner decides to extend beyond 2021-08-01
No Result:data-review+ |
3 tasks
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 5, 2021
6 tasks
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18163
Pull Request checklist
To download an APK when reviewing a PR: