Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #24333 - Migrate "NoCollectionsMessageViewHolder" to Compose #24455

Closed
wants to merge 1 commit into from
Closed

For #24333 - Migrate "NoCollectionsMessageViewHolder" to Compose #24455

wants to merge 1 commit into from

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Mar 25, 2022 •
edited
Loading

NoCollections.mp4

@sarah541 @gabrielluong Sorry for working on this at the same time.
I'm okay with this serving as a draft for your implementations, will move to the actual collections.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners March 25, 2022 14:29
@Mugurell Mugurell marked this pull request as draft March 25, 2022 14:32
@gabrielluong gabrielluong added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Mar 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏

sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
7311743 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
174348f 
…Compose

No missed a file
@sarah541 sarah541 mentioned this pull request Apr 5, 2022
Merged
3 tasks
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
2dbeb10 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
ebe4792 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
5975d1c 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 6, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
aa590f9 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 7, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
8556fec 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 11, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
98b3ed3 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 11, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
5b96880 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 11, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
5988715 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 11, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
f18dd4f 
…Compose

No missed a file
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 13, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
e4980f7 
…Compose

Some changes
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 13, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
fdbb072 
…Compose

Some changes
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 15, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
e9e145f 
…Compose

Some changes

Some changes
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 20, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
db41f40 
…Compose

Fix comments
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 21, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
9b2e562 
…Compose

Fix comments
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 22, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
a48b1ed 
…Compose

Fix
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 22, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
82e69bc 
…Compose

Fix
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 25, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
3d99e45 
…Compose

Check
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 27, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
ed92bd5 
…Compose

Check
sarah541 added a commit to sarah541/fenix that referenced this pull request Apr 27, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
57382eb 
…Compose

Check
sarah541 added a commit to sarah541/fenix that referenced this pull request May 3, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
27a51e6 
…Compose

Whatever
sarah541 added a commit to sarah541/fenix that referenced this pull request May 3, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
18311f0 
…Compose

Whatever
sarah541 added a commit to sarah541/fenix that referenced this pull request May 5, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
22e994e 
…Compose

Whatever
sarah541 added a commit to sarah541/fenix that referenced this pull request May 7, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
08bdfbe 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request May 7, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
cde69b4 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request May 9, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
c0478f6 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request May 9, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
68137d5 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request May 10, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
9d4679a 
…Compose
sarah541 added a commit to sarah541/fenix that referenced this pull request May 10, 2022
@sarah541
For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHolder to …
ba29146 
…Compose
@mergify mergify bot closed this in #24624 May 10, 2022
mergify bot pushed a commit that referenced this pull request May 10, 2022
@sarah541 @mergify
For #24455 - Migrate NoCollectionsMessageViewHolder to Compose
7b895ab
Amejia481 added a commit to Amejia481/fenix that referenced this pull request Jun 3, 2022
@Amejia481
Revert "For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHo…
170528b 
…lder to Compose"

This reverts commit 7b895ab
Amejia481 added a commit to Amejia481/fenix that referenced this pull request Jun 3, 2022
@Amejia481
Revert "For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHo…
1d27471 
…lder to Compose"

This reverts commit 7b895ab
Amejia481 added a commit to Amejia481/fenix that referenced this pull request Jun 3, 2022
@Amejia481
Revert "For mozilla-mobile#24455 - Migrate NoCollectionsMessageViewHo…
c7ef1fc 
…lder to Compose"

This reverts commit 7b895ab
mergify bot pushed a commit that referenced this pull request Jun 5, 2022
@Amejia481 @mergify
Revert "For #24455 - Migrate NoCollectionsMessageViewHolder to Compose"
6a33f29 
This reverts commit 7b895ab
@mcomella mcomella mentioned this pull request Jun 6, 2022
Closed
mergify bot pushed a commit that referenced this pull request Jun 7, 2022
@Amejia481 @mergify
Revert "For #24455 - Migrate NoCollectionsMessageViewHolder to Compose"
0da7ec5 
This reverts commit 7b895ab

(cherry picked from commit 6a33f29)
Amejia481 added a commit that referenced this pull request Jun 7, 2022
@Amejia481
Revert "For #24455 - Migrate NoCollectionsMessageViewHolder to Compose"
e7bac4f 
This reverts commit 7b895ab

(cherry picked from commit 6a33f29)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugurell @gabrielluong