move various tools to avoid main func collisions #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These Go files all contained `func main`s that conflicted with other `main`s in the same directory. Only one of these tools are used in our build or referenced in our docs, and that use (in our softhsm Dockerfile) is adjusted. This was done because various tools complain and break. For instance, `go build ./...`. Now the `...` alias in Go tooling works again. This was figured out while working on porting the linting work to GitHub Actions. Updates AUT-192 Updates AUT-197
jmhodges
added a commit
that referenced
this pull request
Aug 15, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable everytime we want to test or lint a new package in CI and locally.
jmhodges
added a commit
that referenced
this pull request
Aug 15, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable every time we want to test or lint a new package in CI and locally.
bhearsum
approved these changes
Aug 16, 2024
jmhodges
added a commit
that referenced
this pull request
Aug 26, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable every time we want to test or lint a new package in CI and locally.
jmhodges
added a commit
that referenced
this pull request
Aug 26, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable every time we want to test or lint a new package in CI and locally.
jmhodges
added a commit
that referenced
this pull request
Aug 26, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable every time we want to test or lint a new package in CI and locally. Updates AUT-192
jmhodges
added a commit
that referenced
this pull request
Aug 26, 2024
Now that we've stopped our tools from conflicting over `func main`, we can use the Go tooling's `./...` alias to make them operate over all of our packages. See `go help packages` for more on `...`. (Those conflicts were solved in #947). This means we no longer have to remember to update this variable every time we want to test or lint a new package in CI and locally. Updates AUT-192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Go files all contained
func mains that conflicted with othermains in the same directory. Only one of these tools are used in ourbuild or referenced in our docs, and that use (in our softhsm
Dockerfile) is adjusted.
This was done because various tools complain and break. For instance,
go build ./.... Now the...alias in Go tooling works again.This was figured out while working on porting the linting work to GitHub
Actions.
Updates AUT-192
Updates AUT-197